Add sof-v2.9 for Intel hardware #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
plbossart,
lgirdwood,
ujfalusi,
abonislawski,
fredoh9 and
mwasko
|
V2 uploaded, now tests pass. |
kv2019i
force-pushed
the
202403-sof29-community
branch
from
bf00d93 to
559970b
Compare
|
V3: fix tarball_multi_releases
V4: fix BATS tests again |
kv2019i
force-pushed
the
202403-sof29-community
branch
from
559970b to
99ca1e7
Compare
|
V5: one more fixup to the sof-ace-tplg symlink handling |
ujfalusi
approved these changes
Mar 28, 2024
kv2019i
force-pushed
the
202403-sof29-community
branch
from
99ca1e7 to
2296aba
Compare
|
The community binaries have "v2.9-rc1" tag (it's the same commit as v2.9 tag), causing difference in binaries. We really should get rid of this in SOF main. |
abonislawski
approved these changes
Mar 28, 2024
|
V6:
|
marc-hb
reviewed
Mar 29, 2024
| # the compatibility note for Intel MTL in | ||
| # https://thesofproject.github.io/latest/getting_started/intel_debug/introduction.html#user-space-and-filesystem-requirements | ||
| ( cd "${archive_name}" | ||
| if test -e "sof-ipc4-tplg-WIP" -a ! -e "sof-ace-tplg-WIP" ; then |
There was a problem hiding this comment.
shellcheck would likely say:
Suggested change
| if test -e "sof-ipc4-tplg-WIP" -a ! -e "sof-ace-tplg-WIP" ; then | |
| if test -e "sof-ipc4-tplg-WIP" && ! test -e "sof-ace-tplg-WIP" ; then |
There was a problem hiding this comment.
@marc-hb Hmm, shellcheck seems happy with original.
tests/tests.bats
Outdated
| diff -qr "$EXTR_REFS"/sof-bin-"$ver" "$(pwd)/sof-bin-$ver"/ | ||
| # install.sh was updated in 2024.03, so it won't match | ||
| # anymore | ||
| diff -qr --exclude="install.sh" "$EXTR_REFS"/sof-bin-"$ver" "$(pwd)/sof-bin-$ver"/ |
There was a problem hiding this comment.
Can you please try this instead?
git show v2023.12.1:install.sh > "$(pwd)/sof-bin-$ver"/install.sh
v2.9.x/tools-v2.9/mtrace-reader.py
Outdated
There was a problem hiding this comment.
Was there any tools change between v2.8 and v2.9? If not, can you just re-use tools-v2.8 and reduce noice?
There was a problem hiding this comment.
@marc-hb There was a minor change in sof-ctl, so we need to update.
Add binaries for supported Intel systems. Community binaries build identification "Build #3513". Also contains topology2/IPC4 topology files for all configurations supported in the release. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add support for new sof-ipc4-tplg directory as documented in updated SOF user-space and filesystem requirements. Link: https://thesofproject.github.io/latest/getting_started/intel_debug/introduction.html#user-space-and-filesystem-requirements Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
The install.sh has been updated to include more directories, so recreating 2023.09 will cause a mismatch in installed install.sh. Exclude the known difference in the test case. Suggested-by: Marc Herbert <marc.herbert@intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
…link Not ideal, but it seems adding a special case rule is easier to understand and maintain than trying to modify the existing FW/tplg copy rules to handle this special case. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add signed Intel binaries for v2.9 SOF release. Intel build identification 13778510. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202403-sof29-community
branch
from
d2ea2ef to
1edb6ca
Compare
|
V7:
@marc-hb please check |
marc-hb
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.