DMI remap for rebranded Intel NUC M15 (LAPRC710) laptops #4744
Conversation
mosomate
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
|
Can one of the admins verify this patch?
|
| .driver_data = (void *)(SOF_SDW_TGL_HDMI | | ||
| SOF_SDW_PCH_DMIC | | ||
| RT711_JD2_100K), | ||
| }, |
There was a problem hiding this comment.
Can we remove the /* NUC15 'Rooks County' LAPRC510 and LAPRC710 skews */ entry if this is more generic?
There was a problem hiding this comment.
I'd say no. My suggestion is more generic, but handles only the LAPRC710 version (genuine Intel and rebranded variants as well). The entry above my suggestion handles both LAPRC510 and LAPRC710 versions, but only the genuine Intel variants. As much as I know, the LAPRC510 wasn't rebranded and marketed that way, so it doesn't need to be handled "in a generic" way. I think if we leave the code in this state it handles all the cases.
| @@ -130,6 +130,14 @@ static const struct dmi_system_id adr_remap_quirk_table[] = { | |||
| }, | |||
| .driver_data = (void *)intel_rooks_county, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
@mosomate please modify the commit title include the prefix and add a proper commit message along with your sign-off and link to the issue.
There was a problem hiding this comment.
@ranj063 I modified the commit message. I hope it fulfills the guidelines now. I'm sorry, this is my first time contributing to the linux kernel.
… laptops Added DMI quirk to handle the rebranded variants of Intel NUC M15 (LAPRC710) laptops. The DMI matching is based on motherboard attributes. Link: thesofproject#4218 Signed-off-by: Máté Mosonyi <mosomate@gmail.com>
mosomate
force-pushed
the
topic/sof-dev
branch
from
9beaca2 to
aab5b01
Compare
|
test this please |
Discussed in #4218. This DMI remapping problem was partially handled in #4088. But this solution doesn't work for rebranded versions of the NUC M15 laptop (like Schenker, XPG, etc...). I added a more generic DMI quirk based on the motherboard attributes.