fixup! ASoC: SOF: Intel: hda-dai-ops: fix HDaudio link format #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plbossart
requested review from
lgirdwood,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
|
Confirmed that this PR can fix issue #4739. |
bardliao
previously approved these changes
Dec 11, 2023
ujfalusi
reviewed
Dec 14, 2023
We need to make sure the ch_mask is not zero! The ch_maps only contains information on codec/cpu connection by default, the ch_mask needs to be set explicitly and this isn't done except for SoundWire links. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
fix/bad-ch-maps-handling
branch
from
118847a to
322da86
Compare
bardliao
approved these changes
Dec 18, 2023
ujfalusi
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure the ch_mask is not zero!
The ch_maps only contains information on codec/cpu connection by default, the ch_mask needs to be set explicitly and this isn't done except for SoundWire links.