Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show "Your drop is being prepared" when user not connected #916

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

kkosiorowska
Copy link
Contributor

@kkosiorowska kkosiorowska commented Dec 5, 2024

Closes AENG-173

We shouldn't show the "Please wait…. Your drop is being prepared" when the user is not logged in. This PR improves the logic of displaying acre points info. Now a user who is not logged in can always see information about the next drop. Additionally, the points data will be displayed only if they are fetched.

Before

Screenshot 2024-12-12 at 11 51 20 Screenshot 2024-12-12 at 11 55 41

After

Screenshot 2024-12-12 at 11 39 18 Screenshot 2024-12-12 at 11 56 53

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit d801c79
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/676006d458287b0008c5cb8a
😎 Deploy Preview https://deploy-preview-916--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit d801c79
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/676006d43ea53a0008b1dec5
😎 Deploy Preview https://deploy-preview-916--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkosiorowska kkosiorowska changed the base branch from main to reset-activities December 12, 2024 08:28
Copy link

linear bot commented Dec 12, 2024

@kkosiorowska kkosiorowska added the 🐛 Bug Something isn't working label Dec 12, 2024
Base automatically changed from reset-activities to main December 12, 2024 11:02
@kkosiorowska kkosiorowska marked this pull request as ready for review December 12, 2024 11:02
@kpyszkowski kpyszkowski merged commit 49fd298 into main Dec 16, 2024
26 of 28 checks passed
@kpyszkowski kpyszkowski deleted the fix-drop-message branch December 16, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants