Update the directory structure in the dApp #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
If there's only an index file, there's no need to have a directory with an index.* file. The idea with using index.tsx is that imports can remain unchanged in cases where we upgrade from having a single-file component to needing scoped sibling components.
kkosiorowska
force-pushed
the
update-directory-structure
branch
from
98de67d to
6e4c0aa
Compare
We should not decouple file name from component name—these should match.
kkosiorowska
force-pushed
the
update-directory-structure
branch
from
4505850 to
ef61f7d
Compare
nkuba
reviewed
Dec 5, 2024
dapp/src/components/TransactionModal/ActiveStakingStep/StakeFormModal/StakeDetails.tsx
Show resolved
Hide resolved
r-czajkowski
previously approved these changes
Dec 6, 2024
nkuba
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AENG-158
This PR fixes the directory structure for dApp a bit. Let's make further possible tweaks in the next PRs. What has been done: