Set Sentry user id to hashed identifier #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We calculate the ID of the user by hashing the address. This way we won't store any sensitive information in Sentry.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dapp/src/sentry.test.ts
Outdated
There was a problem hiding this comment.
We keep the tests in separate directories. So I'm wondering whether to move them to the tests folder.
We don't need to introduce another crypto-js library to calculate the hash. We can use the existing ethers library.
r-czajkowski
approved these changes
Nov 28, 2024
r-czajkowski
added a commit
that referenced
this pull request
Dec 9, 2024
Depends on: #904 For consistency with other packages and projects we are moving the dapp tests to the root test folder. There are many possible approaches to organize the tests, but here we are following the same structure as the other packages. If we need to change this in the future, we can discuss and find the best approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculate the ID of the user by hashing the address. This way we won't store any sensitive information in Sentry.