Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/adopt pnpm #21

Merged
merged 10 commits into from
Jan 27, 2025
Merged

enhancement/adopt pnpm #21

merged 10 commits into from
Jan 27, 2025

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Nov 21, 2024 •
edited
Loading

Changes

  1. resolves demonstrate usage of PNPM #22

Upstreams

  1. PNPM support (not hardcoding location of node_modules on disk) ProjectEvergreen/greenwood#1313
  2. leverage import.meta.resolve to support import maps generation and accurate node_modules resolution when building ProjectEvergreen/greenwood#684

TODOs

  1. Products route seems to have a 404 request (lit hydration script?)
    Screenshot 2024-11-27 at 12 56 02 PM
  2. ✅ Make sure [demo] Shoelace #23 is working (dev and production)
  3. ✅ Make sure [demo] Spectrum Web Components #24 is working (dev and production - one unrelated issue remains)
  4. ✅ Make sure [demo] USWDS #26 is working (dev and production)

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
greenwood-lit-ssr-yp27 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 6:17pm

@thescientist13 thescientist13 marked this pull request as draft November 21, 2024 19:22
@thescientist13 thescientist13 linked an issue Nov 23, 2024 that may be closed by this pull request
demonstrate usage of PNPM #22
Closed
@thescientist13 thescientist13 added the enhancement New feature or request label Nov 23, 2024
@thescientist13 thescientist13 mentioned this pull request Nov 23, 2024
Open
2 tasks
This was referenced Nov 27, 2024
Open
Draft
Merged
@thescientist13 thescientist13 mentioned this pull request Dec 2, 2024
Closed
40 tasks
@thescientist13 thescientist13 mentioned this pull request Dec 8, 2024
Merged
11 tasks
@thescientist13 thescientist13 mentioned this pull request Jan 18, 2025
Closed
@thescientist13 thescientist13 marked this pull request as ready for review January 26, 2025 00:43
@thescientist13 thescientist13 changed the title adopt pnpm enhancement/adopt pnpm Jan 27, 2025
@thescientist13 thescientist13 merged commit 311f74c into main Jan 27, 2025
2 checks passed
@thescientist13 thescientist13 deleted the adopt-pnpm branch January 27, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

demonstrate usage of PNPM
1 participant
@thescientist13