Target object with old and new receiving 0

[AfonsoMeirelesSilva]

My InsertEvent(AudiEvent) from my Provider is receiving a int property always with 0.

my properties is something lik
Id {get; protected set;}
Name {get; protected set;}

Funny part, changes made to Name are being tracked, with OldName and NewName, but to the Id is not, always wiht 0.

[thepirat000]

What kind of audit events? Are you auditing with Audit.EntityFramework.* ? Please give more context

[AfonsoMeirelesSilva]

Its a simple Event, something like thid does:

Audit.Core.Configuration.Setup()
  .UseDynamicAsyncProvider(config => config
    .OnInsert(async ev => await File.WriteAllTextAsync(filePath, ev.ToJson())));

But my Int property has a 0 value, i can fix it removing the protected set from property, but its not suppose to do that :)

[thepirat000]

The issue with the protected setter is that the library attempts to clone the target object to save the "old" state in memory when creating the audit scope (here). This cloning process is performed by invoking the CloneValue method in the DataProvider. The default implementation works as follows:

auditEvent.Target.Old = Deserialize(Serialize(target))

The problem arises because the JSON serializer cannot deserialize protected properties, which is why the default values are being displayed.

You have a few options to resolve this:

1. Use public setters.

or

2. Make your class have a single public constructor that takes the property values as parameters.

public class Person
{
    protected Person() { }

    public Person(int id, string name)
    {
        Id = id;
        Name = name;
    }

    public int Id { get; protected set; }
    public string Name { get; protected set; }
}

Note that the parameterless constructor should not be public; otherwise, the deserializer will attempt to create an instance by calling the parameterless constructor.

or

3. Override the Clone method in a custom DataProvider.

using Audit.Core;
using Audit.Core.Providers;
using Audit.Core.ConfigurationApi;

public class MyDataProvider : FileDataProvider
{
    public MyDataProvider(Action<IFileLogProviderConfigurator> config) : base(config) { }

    public override object CloneValue<T>(T value, AuditEvent auditEvent)
    {
        if (value is Person person)
        {
            return new Person(person.Id, person.Name);
        }
        else
        {
            return base.CloneValue(value, auditEvent);
        }
    }
}

// configure it with
Audit.Core.Configuration.Setup()
    .Use(new MyDataProvider(cfg => cfg
        .Directory(@"C:\Logs")
        .FilenameBuilder(_ => $"{DateTime.Now:yyyyMMddHHmmssffff}.json")));

[AfonsoMeirelesSilva]

My current solution is,serialize the object during the creationing of Audit.Create

var scope = AuditScope.Create(new AuditScopeOptions()
{
  EventType = "Order:Update",
  TargetGetter = (target) => {
  //serialize target 

 return serializedTarget(target);
  }, 
  ExtraFields = new { MyProperty = "value" }
});

I`m doing this way because when the Audit is created, the target object is being mapped to the Provider with the "issue".

Calls to the overrided Clone method are made before or after the call to the provider ?

[thepirat000]

The clone operation is invoked twice: first, during the creation of the audit scope to capture the Target.Old value, and again when the event ends (prior to saving) to populate the Target.New value

[AfonsoMeirelesSilva]

Thanks man, serializing the target lookgs a great solution, for now, i`ll try to map track only the fields changed :)