Skip to content

Commit

Permalink
Change: Remove v prefix from docker tags
Browse files Browse the repository at this point in the history
Docker image tag conventions are starting to become clear that it is preferred to omit `v` prefix. While having the `v` prefix in the past might have been common, it is becoming less and less common today, with most of docker official images
(https://github.com/docker-library/official-image) omitting the `v` prefix.
  • Loading branch information
leojonathanoh committed Sep 27, 2023
1 parent 3c01211 commit 5e69a75
Show file tree
Hide file tree
Showing 168 changed files with 20,008 additions and 890 deletions.
1,650 changes: 825 additions & 825 deletions .github/workflows/ci-master-pr.yml

Large diffs are not rendered by default.

126 changes: 63 additions & 63 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,63 +10,63 @@ Dockerized [`code-server`](https://github.com/coder/code-server).

| Tag | Dockerfile Build Context |
|:-------:|:---------:|
| `:v4.16.1`, `:latest` | [View](variants/v4.16.1) |
| `:v4.16.1-docker` | [View](variants/v4.16.1-docker) |
| `:v4.16.1-docker-go-1.20.8` | [View](variants/v4.16.1-docker-go-1.20.8) |
| `:v4.16.1-docker-rootless` | [View](variants/v4.16.1-docker-rootless) |
| `:v4.16.1-docker-rootless-go-1.20.8` | [View](variants/v4.16.1-docker-rootless-go-1.20.8) |
| `:v4.15.0` | [View](variants/v4.15.0) |
| `:v4.15.0-docker` | [View](variants/v4.15.0-docker) |
| `:v4.15.0-docker-go-1.20.8` | [View](variants/v4.15.0-docker-go-1.20.8) |
| `:v4.15.0-docker-rootless` | [View](variants/v4.15.0-docker-rootless) |
| `:v4.15.0-docker-rootless-go-1.20.8` | [View](variants/v4.15.0-docker-rootless-go-1.20.8) |
| `:v4.14.1` | [View](variants/v4.14.1) |
| `:v4.14.1-docker` | [View](variants/v4.14.1-docker) |
| `:v4.14.1-docker-go-1.20.8` | [View](variants/v4.14.1-docker-go-1.20.8) |
| `:v4.14.1-docker-rootless` | [View](variants/v4.14.1-docker-rootless) |
| `:v4.14.1-docker-rootless-go-1.20.8` | [View](variants/v4.14.1-docker-rootless-go-1.20.8) |
| `:v4.13.0` | [View](variants/v4.13.0) |
| `:v4.13.0-docker` | [View](variants/v4.13.0-docker) |
| `:v4.13.0-docker-go-1.20.8` | [View](variants/v4.13.0-docker-go-1.20.8) |
| `:v4.13.0-docker-rootless` | [View](variants/v4.13.0-docker-rootless) |
| `:v4.13.0-docker-rootless-go-1.20.8` | [View](variants/v4.13.0-docker-rootless-go-1.20.8) |
| `:v4.12.0` | [View](variants/v4.12.0) |
| `:v4.12.0-docker` | [View](variants/v4.12.0-docker) |
| `:v4.12.0-docker-go-1.20.8` | [View](variants/v4.12.0-docker-go-1.20.8) |
| `:v4.12.0-docker-rootless` | [View](variants/v4.12.0-docker-rootless) |
| `:v4.12.0-docker-rootless-go-1.20.8` | [View](variants/v4.12.0-docker-rootless-go-1.20.8) |
| `:v4.11.0` | [View](variants/v4.11.0) |
| `:v4.11.0-docker` | [View](variants/v4.11.0-docker) |
| `:v4.11.0-docker-go-1.20.8` | [View](variants/v4.11.0-docker-go-1.20.8) |
| `:v4.11.0-docker-rootless` | [View](variants/v4.11.0-docker-rootless) |
| `:v4.11.0-docker-rootless-go-1.20.8` | [View](variants/v4.11.0-docker-rootless-go-1.20.8) |
| `:v4.10.1` | [View](variants/v4.10.1) |
| `:v4.10.1-docker` | [View](variants/v4.10.1-docker) |
| `:v4.10.1-docker-go-1.20.8` | [View](variants/v4.10.1-docker-go-1.20.8) |
| `:v4.10.1-docker-rootless` | [View](variants/v4.10.1-docker-rootless) |
| `:v4.10.1-docker-rootless-go-1.20.8` | [View](variants/v4.10.1-docker-rootless-go-1.20.8) |
| `:v4.9.1` | [View](variants/v4.9.1) |
| `:v4.9.1-docker` | [View](variants/v4.9.1-docker) |
| `:v4.9.1-docker-go-1.20.8` | [View](variants/v4.9.1-docker-go-1.20.8) |
| `:v4.9.1-docker-rootless` | [View](variants/v4.9.1-docker-rootless) |
| `:v4.9.1-docker-rootless-go-1.20.8` | [View](variants/v4.9.1-docker-rootless-go-1.20.8) |
| `:v4.8.3` | [View](variants/v4.8.3) |
| `:v4.8.3-docker` | [View](variants/v4.8.3-docker) |
| `:v4.8.3-docker-go-1.20.8` | [View](variants/v4.8.3-docker-go-1.20.8) |
| `:v4.8.3-docker-rootless` | [View](variants/v4.8.3-docker-rootless) |
| `:v4.8.3-docker-rootless-go-1.20.8` | [View](variants/v4.8.3-docker-rootless-go-1.20.8) |
| `:v4.7.1` | [View](variants/v4.7.1) |
| `:v4.7.1-docker` | [View](variants/v4.7.1-docker) |
| `:v4.7.1-docker-go-1.20.8` | [View](variants/v4.7.1-docker-go-1.20.8) |
| `:v4.7.1-docker-rootless` | [View](variants/v4.7.1-docker-rootless) |
| `:v4.7.1-docker-rootless-go-1.20.8` | [View](variants/v4.7.1-docker-rootless-go-1.20.8) |
| `:v4.6.1` | [View](variants/v4.6.1) |
| `:v4.6.1-docker` | [View](variants/v4.6.1-docker) |
| `:v4.6.1-docker-go-1.20.8` | [View](variants/v4.6.1-docker-go-1.20.8) |
| `:v4.6.1-docker-rootless` | [View](variants/v4.6.1-docker-rootless) |
| `:v4.6.1-docker-rootless-go-1.20.8` | [View](variants/v4.6.1-docker-rootless-go-1.20.8) |

Base variants are based on `alpine`, and include `npm 8` and `nodejs 16` (to run `code-server`), `pwsh`, and basic tools. E.g. `v4.16.1`
| `:4.16.1`, `:latest` | [View](variants/4.16.1) |
| `:4.16.1-docker` | [View](variants/4.16.1-docker) |
| `:4.16.1-docker-go-1.20.8` | [View](variants/4.16.1-docker-go-1.20.8) |
| `:4.16.1-docker-rootless` | [View](variants/4.16.1-docker-rootless) |
| `:4.16.1-docker-rootless-go-1.20.8` | [View](variants/4.16.1-docker-rootless-go-1.20.8) |
| `:4.15.0` | [View](variants/4.15.0) |
| `:4.15.0-docker` | [View](variants/4.15.0-docker) |
| `:4.15.0-docker-go-1.20.8` | [View](variants/4.15.0-docker-go-1.20.8) |
| `:4.15.0-docker-rootless` | [View](variants/4.15.0-docker-rootless) |
| `:4.15.0-docker-rootless-go-1.20.8` | [View](variants/4.15.0-docker-rootless-go-1.20.8) |
| `:4.14.1` | [View](variants/4.14.1) |
| `:4.14.1-docker` | [View](variants/4.14.1-docker) |
| `:4.14.1-docker-go-1.20.8` | [View](variants/4.14.1-docker-go-1.20.8) |
| `:4.14.1-docker-rootless` | [View](variants/4.14.1-docker-rootless) |
| `:4.14.1-docker-rootless-go-1.20.8` | [View](variants/4.14.1-docker-rootless-go-1.20.8) |
| `:4.13.0` | [View](variants/4.13.0) |
| `:4.13.0-docker` | [View](variants/4.13.0-docker) |
| `:4.13.0-docker-go-1.20.8` | [View](variants/4.13.0-docker-go-1.20.8) |
| `:4.13.0-docker-rootless` | [View](variants/4.13.0-docker-rootless) |
| `:4.13.0-docker-rootless-go-1.20.8` | [View](variants/4.13.0-docker-rootless-go-1.20.8) |
| `:4.12.0` | [View](variants/4.12.0) |
| `:4.12.0-docker` | [View](variants/4.12.0-docker) |
| `:4.12.0-docker-go-1.20.8` | [View](variants/4.12.0-docker-go-1.20.8) |
| `:4.12.0-docker-rootless` | [View](variants/4.12.0-docker-rootless) |
| `:4.12.0-docker-rootless-go-1.20.8` | [View](variants/4.12.0-docker-rootless-go-1.20.8) |
| `:4.11.0` | [View](variants/4.11.0) |
| `:4.11.0-docker` | [View](variants/4.11.0-docker) |
| `:4.11.0-docker-go-1.20.8` | [View](variants/4.11.0-docker-go-1.20.8) |
| `:4.11.0-docker-rootless` | [View](variants/4.11.0-docker-rootless) |
| `:4.11.0-docker-rootless-go-1.20.8` | [View](variants/4.11.0-docker-rootless-go-1.20.8) |
| `:4.10.1` | [View](variants/4.10.1) |
| `:4.10.1-docker` | [View](variants/4.10.1-docker) |
| `:4.10.1-docker-go-1.20.8` | [View](variants/4.10.1-docker-go-1.20.8) |
| `:4.10.1-docker-rootless` | [View](variants/4.10.1-docker-rootless) |
| `:4.10.1-docker-rootless-go-1.20.8` | [View](variants/4.10.1-docker-rootless-go-1.20.8) |
| `:4.9.1` | [View](variants/4.9.1) |
| `:4.9.1-docker` | [View](variants/4.9.1-docker) |
| `:4.9.1-docker-go-1.20.8` | [View](variants/4.9.1-docker-go-1.20.8) |
| `:4.9.1-docker-rootless` | [View](variants/4.9.1-docker-rootless) |
| `:4.9.1-docker-rootless-go-1.20.8` | [View](variants/4.9.1-docker-rootless-go-1.20.8) |
| `:4.8.3` | [View](variants/4.8.3) |
| `:4.8.3-docker` | [View](variants/4.8.3-docker) |
| `:4.8.3-docker-go-1.20.8` | [View](variants/4.8.3-docker-go-1.20.8) |
| `:4.8.3-docker-rootless` | [View](variants/4.8.3-docker-rootless) |
| `:4.8.3-docker-rootless-go-1.20.8` | [View](variants/4.8.3-docker-rootless-go-1.20.8) |
| `:4.7.1` | [View](variants/4.7.1) |
| `:4.7.1-docker` | [View](variants/4.7.1-docker) |
| `:4.7.1-docker-go-1.20.8` | [View](variants/4.7.1-docker-go-1.20.8) |
| `:4.7.1-docker-rootless` | [View](variants/4.7.1-docker-rootless) |
| `:4.7.1-docker-rootless-go-1.20.8` | [View](variants/4.7.1-docker-rootless-go-1.20.8) |
| `:4.6.1` | [View](variants/4.6.1) |
| `:4.6.1-docker` | [View](variants/4.6.1-docker) |
| `:4.6.1-docker-go-1.20.8` | [View](variants/4.6.1-docker-go-1.20.8) |
| `:4.6.1-docker-rootless` | [View](variants/4.6.1-docker-rootless) |
| `:4.6.1-docker-rootless-go-1.20.8` | [View](variants/4.6.1-docker-rootless-go-1.20.8) |

Base variants are based on `alpine`, and include `npm 8` and `nodejs 16` (to run `code-server`), `pwsh`, and basic tools. E.g. `4.16.1`

Incremental variants include additional tools and their `code` extensions:

Expand All @@ -79,29 +79,29 @@ Incremental variants include additional tools and their `code` extensions:
### Base variant(s)

```sh
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:v4.16.1
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:4.16.1
# code-server is now available at http://127.0.0.1:8080. To login, use the password in the config file: --bind-addr=0.0.0.0:8080 --auth=none --disable-telemetry --disable-update-check
docker exec code-server sh -c 'cat ~/.config/code-server/config.yaml'
```

To disable password authentication, use `--auth=none`:

```sh
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:v4.16.1 --bind-addr=0.0.0.0:8080 --auth=none --disable-telemetry --disable-update-check
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:4.16.1 --bind-addr=0.0.0.0:8080 --auth=none --disable-telemetry --disable-update-check
```

### `docker` variant(s)

```sh
docker run --name code-server --rm -it --privileged -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:v4.16.1-docker
docker run --name code-server --rm -it --privileged -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:4.16.1-docker
# code-server is now available at http://127.0.0.1:8080. To login, use the password in the config file:
docker exec code-server sh -c 'cat ~/.config/code-server/config.yaml'
```

To disable password authentication, use `--auth=none`:

```sh
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:v4.16.1-docker --bind-addr=0.0.0.0:8080 --auth=none --disable-telemetry --disable-update-check
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:4.16.1-docker --bind-addr=0.0.0.0:8080 --auth=none --disable-telemetry --disable-update-check
```

#### docker buildx
Expand Down Expand Up @@ -129,15 +129,15 @@ docker buildx build ...
### `docker-rootless` variant(s)

```sh
docker run --name code-server --rm -it --privileged -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:v4.16.1-docker-rootless
docker run --name code-server --rm -it --privileged -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:4.16.1-docker-rootless
# code-server is now available at http://127.0.0.1:8080. To login, use the password in the config file:
docker exec code-server sh -c 'cat ~/.config/code-server/config.yaml'
```

To start code-server without password authentication, use `--auth=none`:

```sh
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:v4.16.1-docker-rootless --bind-addr=0.0.0.0:8080 --auth=none --disable-telemetry --disable-update-check
docker run --name code-server --rm -it -p 127.0.0.1:8080:8080 theohbrothers/docker-code-server:4.16.1-docker-rootless --bind-addr=0.0.0.0:8080 --auth=none --disable-telemetry --disable-update-check
```

To build multi-arch images using `docker buildx`, see [here](#docker-buildx).
Expand Down
4 changes: 2 additions & 2 deletions generate/definitions/VARIANTS.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ $VARIANTS = @(
components = $subVariant['components']
job_group_key = $variant['package_version']
}
# Docker image tag. E.g. 'v2.17.0[-component..]'
# Docker image tag. E.g. '2.17.0' or '2.17.0[-component..]'
tag = @(
"v$( $variant['package_version'] )"
$variant['package_version']
$subVariant['components'] | ? { $_ }
) -join '-'
tag_as_latest = if ($variant['package_version'] -eq $local:VARIANTS_MATRIX[0]['package_version'] -and $subVariant['components'].Count -eq 0) { $true } else { $false }
Expand Down
Loading

0 comments on commit 5e69a75

Please sign in to comment.