Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create WhatWeDo section on philosophy page #99

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

gongtzuuuu
Copy link
Contributor

Why need this change? / Root cause:

Changes made:

  • create WhatWeDo section on philosophy section
Screenshot 2025-01-21 at 10 41 18 PM

Test Scope / Change impact:

@gongtzuuuu gongtzuuuu self-assigned this Jan 21, 2025
@gongtzuuuu gongtzuuuu changed the title feat: create WhatWeDo section on philosophy section feat: create WhatWeDo section on philosophy page Jan 21, 2025
@kylemocode
Copy link
Contributor

截圖 2025-01-22 凌晨12 25 27

There is a similar section in homepage, I have two question:

  1. couldn't we use the same logo ?
  2. Can we make this description to some constant ? it is the same in this two section

@ChengYiLin
Copy link
Contributor

There is a similar section in homepage, I have two question:

  1. couldn't we use the same logo ?
  2. Can we make this description to some constant ? it is the same in this two section

I agree that images can be shared.
As for the description, I don't feel strongly about whether it needs to be extracted into a constant.

@gongtzuuuu gongtzuuuu force-pushed the feat/about-philosophy-what-we-do-section branch from 323645e to b60b84b Compare January 26, 2025 03:18
@gongtzuuuu gongtzuuuu force-pushed the feat/about-philosophy-what-we-do-section branch from 4d5d947 to 1c992e6 Compare January 26, 2025 09:21
@gongtzuuuu gongtzuuuu merged commit c30ffe1 into main Jan 26, 2025
3 checks passed
@gongtzuuuu gongtzuuuu deleted the feat/about-philosophy-what-we-do-section branch January 26, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(曼陀號理念)曼陀號領航計畫 Section
3 participants