Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobile nav menu design review #149

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: mobile nav menu design review #149

merged 2 commits into from
Feb 5, 2025

Conversation

ChengYiLin
Copy link
Contributor

@ChengYiLin ChengYiLin commented Feb 5, 2025 •
edited
Loading

Why need this change? / Root cause:

Changes made:

  • Reset Accordian open status when opening the MobileCollapseMenu - 513162a
Demo.mp4

To be confirmed ?

  • MobileCollapseMenu text Hover style -> No changes needed

Test Scope / Change impact:

@ChengYiLin ChengYiLin marked this pull request as ready for review February 5, 2025 17:44
@ChengYiLin ChengYiLin merged commit 7ab02b0 into main Feb 5, 2025
3 checks passed
@ChengYiLin ChengYiLin deleted the fix/mobile-nav-menu branch February 5, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylemocode kylemocode kylemocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Design QA) Nav Enhancement
2 participants
@ChengYiLin @kylemocode