Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ProfileCard component & Team Page #106

Merged
merged 10 commits into from
Jan 27, 2025
Merged

feat: ProfileCard component & Team Page #106

merged 10 commits into from
Jan 27, 2025

Conversation

ChengYiLin
Copy link
Contributor

@ChengYiLin ChengYiLin commented Jan 25, 2025 •
edited
Loading

Why need this change? / Root cause:

Changes made:

  • c761a72 : Adjust tailwind.config container max width to 1156px
  • 9c15ba7, f977a61 : Adjust /faq page responsive layout
  • 93503c8 : ProfileCard component
  • ad8fdb6 : constant for page /team
  • 0dba91e : Integrate component ProfileCard into page /team
  • d3876f7 : change 團隊成員 to 執行團隊
My.Movie.mp4

Test Scope / Change impact:

@ChengYiLin ChengYiLin changed the title feat: Team Page feat: ProfileCard component & Team Page Jan 25, 2025
@ChengYiLin ChengYiLin marked this pull request as ready for review January 25, 2025 18:32
gongtzuuuu
gongtzuuuu approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@gongtzuuuu gongtzuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kylemocode
Copy link
Contributor

kylemocode commented Jan 26, 2025 •
edited
Loading

截圖 2025-01-26 上午10 54 08

I notice these warning messages in console, looks like we can add sizes prop to let next do some optimization for us

@kylemocode
Copy link
Contributor

Want to double check that will the dialogue popup be implemented in future PR ?

@ChengYiLin
Copy link
Contributor Author

I notice these warning messages in console, looks like we can add sizes prop to let next do some optimization for us

cb8476a
Add sizes prop to it~

Want to double check that will the dialogue popup be implemented in future PR ?

You mean the slogan popup?
Yeah, it will be implemented in another PR, so I didn’t close issues #69 and #29.
There is no popup on the /team page, as confirmed by the designer.

image

@ChengYiLin ChengYiLin requested a review from kylemocode January 26, 2025 20:28
kylemocode
kylemocode approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@kylemocode kylemocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ChengYiLin ChengYiLin merged commit 0e9a9e5 into main Jan 27, 2025
3 checks passed
@ChengYiLin ChengYiLin deleted the feat/profile-card branch January 27, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylemocode kylemocode kylemocode approved these changes

@gongtzuuuu gongtzuuuu gongtzuuuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

（執行團隊）content filter 與組別邏輯 （共用元件）團隊成員卡片
3 participants
@ChengYiLin @kylemocode @gongtzuuuu