Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn sparse DelayedArray support back on #50

Open
lazappi opened this issue May 12, 2021 · 4 comments
Open

Turn sparse DelayedArray support back on #50

lazappi opened this issue May 12, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@lazappi
Copy link
Member

lazappi commented May 12, 2021

Reminder to do this now that grimbough/rhdf5#79 has been fixed.

To do:

  • Remove the is_sparse() check
  • Update tests
  • Remove code coverage guards
@lazappi
Copy link
Member Author

lazappi commented May 12, 2021

Tried doing this quickly, writing worked ok but it broke reading.

@lazappi lazappi added the bug Something isn't working label May 12, 2021
@LTLA
Copy link
Contributor

LTLA commented May 12, 2021

Will look at this later. I think we need to flip a few flags in h5writeAttributes to properly save it as a UTF-8 string scalar. What was the error?

@lazappi
Copy link
Member Author

lazappi commented May 14, 2021

I probably should have copied it here but from memory, something along the lines of X is not a valid path.

@lazappi
Copy link
Member Author

lazappi commented Oct 17, 2024

Just checked where this is at. If you remove the is_sparse() check in this line:

if (is(ass_list[[a]], "DelayedMatrix") && !is_sparse(ass_list[[a]])) {

Then writing works fine but reading the output file fails with this error:

Error in py_call_impl(callable, call_args$unnamed, call_args$named) : 
  TypeError: unhashable type: 'list'
Error raised while reading key 'X' of <class 'h5py._hl.group.Group'> from /

And this error on the Python side:

TypeError: unhashable type: 'list'
Error raised while reading key 'X' of <class 'h5py._hl.group.Group'> from /

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants