Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coxphfitter #643

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Coxphfitter #643

merged 14 commits into from
Jan 23, 2024

Conversation

fatisati
Copy link
Contributor

@fatisati fatisati requested a review from Zethson January 22, 2024 13:16
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A few requests.

Don't also forget to import this function and potentially add it to the docs (usage.md)

ehrapy/tools/_sa.py Outdated Show resolved Hide resolved
ehrapy/tools/_sa.py Show resolved Hide resolved
ehrapy/tools/_sa.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the chore label Jan 22, 2024
@fatisati fatisati requested a review from Zethson January 22, 2024 14:00
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments..

ehrapy/tools/_sa.py Outdated Show resolved Hide resolved
ehrapy/tools/_sa.py Outdated Show resolved Hide resolved
ehrapy/tools/_sa.py Outdated Show resolved Hide resolved
ehrapy/tools/_sa.py Outdated Show resolved Hide resolved
ehrapy/tools/_sa.py Show resolved Hide resolved
@fatisati fatisati requested a review from Zethson January 22, 2024 14:25
ehrapy/tools/_sa.py Outdated Show resolved Hide resolved
@fatisati fatisati force-pushed the coxphfitter branch 2 times, most recently from 67ae9e4 to 35ed4f3 Compare January 23, 2024 08:59
@fatisati fatisati requested a review from Zethson January 23, 2024 08:59
Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson Zethson merged commit 68d6498 into main Jan 23, 2024
12 of 19 checks passed
@Zethson Zethson deleted the coxphfitter branch April 17, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants