[Take 3 - Simplified Complete Solution] A way to use ja_serializer with a vanilla phoenix 1.7.X app - without using the fallback phoenix_view package #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theirishpenguin
commented
Aug 31, 2023
| @@ -38,7 +38,7 @@ defmodule Example17xAppWeb do | |||
| def controller do | |||
| quote do | |||
| use Phoenix.Controller, | |||
| formats: [:html, :json], | |||
| formats: [:html, :json, :"json-api"], | |||
There was a problem hiding this comment.
Based on the mime type in config/config.exs, I appear to be forced to add "json-api" here (because of the dash I need to define it as a stringy atom).
theirishpenguin
commented
Aug 31, 2023
| # in the function (as shown below in the show() function). For more details on put_view() usage look under | ||
| # the render() documenation at https://hexdocs.pm/phoenix/0.10.0/Phoenix.Controller.html#render/3 | ||
| # | ||
| plug :put_view, Example17xAppWeb.ThingView |
There was a problem hiding this comment.
To use phoenix 1.7.X directly (as part of the approach in this PR), we need to use put_view() as otherwise phoenix 1.7.X will expect a name like Example17xAppWeb.ThingJSON-API for the view layer module.
(This is because phoenix will try to initially base the name on the :"json-api" format configured earlier).
theirishpenguin
commented
Aug 31, 2023
| @@ -1,5 +1,4 @@ | |||
| defmodule Example17xAppWeb.ThingView do | |||
| use Example17xAppWeb, :view | |||
There was a problem hiding this comment.
We can't use use Example17xAppWeb, :view (well, not without creating it) as phoenix has moved away from this idea with the move to phoenix 1.7.X.
theirishpenguin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR follows on from vt-elixir/ja_serializer#346 (comment) and is an attempt to document a reasonable way of using ja_serializer with phoenix 1.7.7 without using the fallback
phoenix_viewpackage.With these changes in place the simple test suite passes 🥳
Resources useful for understanding the move from phoenix 1.6.X to 1.7.X