Drop absent file declarations #451
Conversation
There was a problem hiding this comment.
The latest addition was in 17.0.0, which was first included in Foreman 3.9. I'm a bit hesitant about that. The others go back to Foreman 3.1, which included 15.0.0 and I feel safe about that.
I'm tempted to wait a bit longer with ${default_ca_name}.pwd, but we don't officially support skipping releases so perhaps it's irrational.
@evgeni mind being the deciding third?
| @@ -23,10 +23,6 @@ | |||
| ) { | |||
| $server_ca_path = "${certs::ssl_build_dir}/${server_ca_name}.crt" | |||
|
|
|||
| file { "${certs::pki_dir}/private/${default_ca_name}.pwd": | |||
| ensure => absent, | |||
There was a problem hiding this comment.
This was ensured absent in 4ba477a, released in 17.0.0.
| # Ensure CA key deployed to /etc/pki/katello/private no longer exists | ||
| # The CA key is not used by anything from this directory and does not need to be deployed | ||
| file { $ca_key: | ||
| ensure => absent, |
There was a problem hiding this comment.
Ensured absent in 028f93a, released in 14.0.0.
| @@ -28,24 +28,6 @@ | |||
| $java_client_cert_name = 'java-client' | |||
| $artemis_alias = 'artemis-client' | |||
| $artemis_client_dn = $certs::foreman::client_dn | |||
|
|
|||
| cert { $java_client_cert_name: | |||
| ensure => absent, | |||
There was a problem hiding this comment.
Ensured absent in 0922645, released in 13.0.0.
| @@ -89,22 +71,6 @@ | |||
| key_decrypt => true, | |||
| } | |||
|
|
|||
| file { "${pki_dir}/private/katello-tomcat.key": | |||
| ensure => absent, | |||
There was a problem hiding this comment.
Ensured absent in 8e00505 and, released in 14.0.0, but I think prior to that already.
|
I like being conservative:) |
|
Is it really backwards incompatible tho? |
|
My reasoning is that you should always be able to upgrade with a minor version without too carefully looking at the release notes while a major version changes it. This just feels safer. |
|
I think now that 18.0.0 is released, we can merge this? |
No description provided.