Merge if/else branch into a single resource declaration

This always defined the same file, just with a different source. That source is either the provided server_ca_cert or the default CA.
theforeman · Sep 12, 2024 · a236b33 · a236b33
1 parent 56f8921
commit a236b33
Showing 1 changed file with 6 additions and 16 deletions.
diff --git a/manifests/ca.pp b/manifests/ca.pp
@@ -46,22 +46,12 @@
     build_dir     => $certs::ssl_build_dir,
   }
 
-  if $certs::server_ca_cert {
-    file { $server_ca_path:
-      ensure => file,
-      source => $certs::server_ca_cert,
-      owner  => 'root',
-      group  => 'root',
-      mode   => '0644',
-    }
-  } else {
-    file { $server_ca_path:
-      ensure => file,
-      source => $default_ca_path,
-      owner  => 'root',
-      group  => 'root',
-      mode   => '0644',
-    }
+  file { $server_ca_path:
+    ensure => file,
+    source => pick($certs::server_ca_cert, $default_ca_path),
+    owner  => 'root',
+    group  => 'root',
+    mode   => '0644',
   }
 
   if $generate {