Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37928 - Support Rails 7.0 #205

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ofedoren
Copy link
Member

No description provided.

@@ -1 +1 @@
gem 'katello', github: 'Katello/katello', branch: 'master'
gem 'katello', github: 'ofedoren/katello', branch: 'feat-37852-support-rails-7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we keep this unmerged until Katello and Foreman get their fixes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and it's mostly to keep this PR green.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test changes are also compatible with Rails 6.1 so can we merge them already?

@ofedoren ofedoren force-pushed the feat-37928-support-rails-7 branch from be8d9c1 to 21757a0 Compare October 22, 2024 15:10
@ofedoren
Copy link
Member Author

Dropped the last commit.

@chris1984 chris1984 merged commit 4de1e56 into theforeman:main Oct 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants