Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37470 - Support Zeitwerk loader #195

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

ofedoren
Copy link
Member

@ofedoren ofedoren commented May 15, 2024

WIP

@chris1984 chris1984 self-assigned this May 15, 2024
@ofedoren ofedoren force-pushed the feat-37470-support-zeitwerk branch from 8993156 to 8d09228 Compare June 22, 2024 16:12
@ofedoren ofedoren marked this pull request as ready for review June 22, 2024 16:23
@ofedoren ofedoren force-pushed the feat-37470-support-zeitwerk branch from 8d09228 to 7aff3b7 Compare July 8, 2024 15:06
@ofedoren ofedoren force-pushed the feat-37470-support-zeitwerk branch from 7aff3b7 to 6b45255 Compare August 30, 2024 13:31
@ofedoren
Copy link
Member Author

ofedoren commented Sep 3, 2024

Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green:
Screenshot_20240903_143351

@ofedoren ofedoren force-pushed the feat-37470-support-zeitwerk branch from 6b45255 to 9ebaad2 Compare September 3, 2024 14:28
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase this just to make sure it passes?

@ofedoren
Copy link
Member Author

It won't: katello is red :/

@ekohl
Copy link
Member

ekohl commented Sep 11, 2024

Now that Katello is merged it should be possible to make it green.

@ofedoren ofedoren force-pushed the feat-37470-support-zeitwerk branch from 9ebaad2 to c57aef5 Compare September 11, 2024 15:29
@chris1984 chris1984 merged commit b0ae4c6 into theforeman:main Sep 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants