Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26319 - Lock Foreman URL field in config #192

Merged
merged 1 commit into from
May 8, 2024
Merged

Fixes #26319 - Lock Foreman URL field in config #192

merged 1 commit into from
May 8, 2024

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented May 1, 2024 •
edited
Loading

What are the changes introduced in this pull request?

  • Locked the Foreman/Satellite URL field so users don't make a mistake with changing that since it's just for info purposes

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  • Check out PR
  • Create a config and verify the field is read only

ianballou
ianballou approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The FQDN is indeed not configurable any longer.

@chris1984 chris1984 merged commit 669f880 into master May 8, 2024
35 checks passed
@chris1984 chris1984 deleted the lock-url branch May 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianballou ianballou ianballou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris1984 @ianballou