Fixes #37382 - Update to jQuery 3 #10138

MariaAga · 2024-04-24T12:46:23Z

Will also need to fix the select2 selectors in plugins, I only found 4 places
https://github.com/search?q=org%3Atheforeman+s2id_++NOT+repo%3Atheforeman%2Fforeman&type=code
https://github.com/search?q=org%3Atheforeman+select2-chosen++NOT+repo%3Atheforeman%2Fforeman&type=code
https://github.com/search?q=s2id_++org%3Akatello&type=code
Requires theforeman/foreman-js#479 to test

ekohl · 2024-04-24T14:50:34Z

I don't see a bump of jquery itself. Is this removing deprecated jquery < 3 usages?

MariaAga · 2024-04-25T11:41:51Z

@ekohl jquery is in theforeman/foreman-js#479

ekohl · 2024-04-25T12:44:42Z

app/assets/javascripts/application.js

-  $('#check_all_roles').click(function(e) {
+  $('#check_all_roles').on('click', function(e) {
    e.preventDefault();
    $('.role_checkbox').prop('checked', true);
  });

-  $('#uncheck_all_roles').click(function(e) {
+  $('#uncheck_all_roles').on('click', function(e) {


I think these are both unused since acfbc45. There the links with check_all_roles and uncheck_all_roles IDs were removed. They were originally added in feacea3.

I've submitted #10141 to drop them.

I also noticed toggleRowGroup, filter_permissions and typeToIcon are now unused.

rebased to include that pr

ekohl · 2024-04-25T12:55:30Z

bundler.d/assets.rb

@@ -1,11 +1,12 @@
 group :assets do
-  gem 'jquery-ui-rails', '~> 6.0'
+  gem 'jquery-ui-rails', '~> 7.0'


Do we still use this? I don't see anything using this. I get the impression that since b55d3ed it's unused because we no longer have require jquery-ui in the code, but we do still have @import jquery-ui. So we load the CSS, but not any of the actual JS code?

Can we drop it?

I think so #10142

ekohl · 2024-05-02T09:10:51Z

app/assets/javascripts/application.js

+$.fn.bind = function(event, func) {
+  return this.on(event, func);
+};
+// used by puppet plugin


Perhaps open a PR against foreman_puppet to drop this usage?

Took a while to setup puppet, but made the pr: theforeman/foreman_puppet#403

ekohl

What's your plan for this? Could we already start using JSON.parse (which AFAIK is native browser functionality)?

Looks like that is also something that needs to be done in multiple repositories. From quickly grepping I find:
https://github.com/theforeman/foreman_puppet/blob/6aa2761cc37bec424c05265a72043706162e3b02/webpack/src/foreman_class_edit.js#L157
https://github.com/theforeman/foreman_puppet/blob/6aa2761cc37bec424c05265a72043706162e3b02/webpack/src/foreman_class_edit.js#L185
https://github.com/theforeman/foreman_openscap/blob/99c00ff3a4c948f660ebe81180cc780c8ff5b0d8/app/assets/javascripts/foreman_openscap/arf_reports.js#L5
https://github.com/Katello/katello/blob/b94f81d09510d135dcc1bdce8a8ef8c2a48c6f39/app/views/katello/sync_management/index.html.erb#L12
https://github.com/Katello/katello/blob/b94f81d09510d135dcc1bdce8a8ef8c2a48c6f39/app/assets/javascripts/katello/common/katello.js#L34

Then another thing we can already do is move to js-cookie. That's something that happens in various repositories. AFAIK jquery's cookie implementation and js-cookie don't conflict, so we can add js-cookie and then migrate various plugins.

MariaAga · 2024-07-18T18:55:48Z

Good idea, I'll move it here: #10250 and will create some prs in the plugins

app/assets/javascripts/application.js

MariaAga · 2025-01-09T14:35:07Z

test failures due to foreman-js not being merged yet probably

jeremylenz

Everything seems to work fine! tested several pages in Katello as well as host edit and hostgroup edit

ekohl · 2025-01-16T21:02:39Z

@MariaAga I'm happy to trust @jeremylenz on his review, but with these bigger changes it can be useful to make some noise on https://community.theforeman.org/c/development/9 that it's happening. Something like https://community.theforeman.org/t/rails-7-0-merge-today/40507 provided a nice place for discussion if it did go wrong. Also something for plugin authors. Pretty sure there are still a few internally maintained plugins by a few users that they need to patch themselves.

MariaAga · 2025-01-17T12:04:02Z

Thanks @ekohl, I created https://community.theforeman.org/t/updating-to-jquery-3/42023

jeremylenz · 2025-01-17T14:53:40Z

Ruby Katello failures are unrelated

adamruzicka

Alright, let's get this in.

ekohl · 2025-01-20T16:47:26Z

To get this in, we'll need to package foreman-js 14. Do you intend to submit a PR for this or do you need help with it?

MariaAga · 2025-01-20T17:13:20Z

@ekohl Created theforeman/foreman-packaging#11640 thanks!

adamruzicka · 2025-01-20T17:15:11Z

There's also theforeman/foreman-packaging#11639 , but I might have gone a little bit overboard with it

ekohl · 2025-01-21T14:08:43Z

package.json

@@ -21,7 +21,7 @@
  },
  "dependencies": {
    "@module-federation/utilities": "^1.7.0",
-    "@theforeman/vendor": "^13.1.0",
+    "@theforeman/vendor": "^14.0.0",


If we update this, we'll also need to merge #10272, right? It's not that we can merge this without updating to PF5.

Eh, but theforeman/foreman-js#481 is still not merged which I assumed was a prerequisite for PF5? Where does that leave us?

vendor 14 doesnt include pf5

Ah, so we'll have version 15 soon after? That's the reason why I had preferred to get rid of foreman-js before making big stack upgrades but I guess that's too late now.

outdated/implemented

MariaAga requested a review from a team as a code owner April 24, 2024 12:46

pr-processor bot added the Not yet reviewed label Apr 24, 2024

github-actions bot added UI Legacy JS PRs making changes in the legacy Javascript stack labels Apr 24, 2024

MariaAga force-pushed the jquery3 branch from a29c4fa to 750cfcb Compare April 24, 2024 14:07

ekohl reviewed Apr 25, 2024

View reviewed changes

MariaAga force-pushed the jquery3 branch from 750cfcb to 750f73e Compare April 25, 2024 13:56

pr-processor bot added the Waiting on contributor label Apr 25, 2024

MariaAga force-pushed the jquery3 branch from 750f73e to a228ca7 Compare May 2, 2024 08:25

pr-processor bot removed the Waiting on contributor label May 2, 2024

ekohl reviewed May 2, 2024

View reviewed changes

ekohl added Waiting on contributor and removed Not yet reviewed labels Jul 18, 2024

ekohl previously requested changes Jul 18, 2024

View reviewed changes

MariaAga force-pushed the jquery3 branch from a228ca7 to 85e1271 Compare July 23, 2024 08:53

pr-processor bot added Needs re-review and removed Waiting on contributor labels Jul 23, 2024

MariaAga commented Jul 23, 2024

View reviewed changes

app/assets/javascripts/application.js Outdated Show resolved Hide resolved

MariaAga force-pushed the jquery3 branch 2 times, most recently from b518403 to 9cb313e Compare December 3, 2024 11:21

MariaAga force-pushed the jquery3 branch from 9cb313e to a0a0522 Compare January 9, 2025 13:34

jeremylenz previously approved these changes Jan 13, 2025

View reviewed changes

pr-processor bot removed the Needs re-review label Jan 13, 2025

MariaAga dismissed jeremylenz’s stale review via 62980df January 13, 2025 15:21

MariaAga force-pushed the jquery3 branch 2 times, most recently from 62980df to 6d846da Compare January 14, 2025 11:39

MariaAga force-pushed the jquery3 branch 4 times, most recently from 6654e5b to 775aa72 Compare January 16, 2025 20:37

adamruzicka approved these changes Jan 20, 2025

View reviewed changes

adamruzicka requested a review from ekohl January 20, 2025 16:39

ekohl reviewed Jan 21, 2025

View reviewed changes

Fixes #37382 - Update to jQuery 3

bbe90d1

evgeni force-pushed the jquery3 branch from 775aa72 to bbe90d1 Compare January 22, 2025 09:37

evgeni approved these changes Jan 22, 2025

View reviewed changes

evgeni merged commit 871a647 into theforeman:develop Jan 22, 2025
39 checks passed

evgeni mentioned this pull request Jan 22, 2025

Bump nodejs-theforeman-{builder,vendor} to 14.0.0 theforeman/foreman-packaging#11648

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #37382 - Update to jQuery 3 #10138

Fixes #37382 - Update to jQuery 3 #10138

MariaAga commented Apr 24, 2024

ekohl commented Apr 24, 2024

MariaAga commented Apr 25, 2024

ekohl Apr 25, 2024

MariaAga May 2, 2024

ekohl Apr 25, 2024

MariaAga Apr 26, 2024

ekohl May 2, 2024

MariaAga Jul 16, 2024

ekohl left a comment

MariaAga commented Jul 18, 2024 •

edited

Loading

MariaAga commented Jan 9, 2025

jeremylenz left a comment

ekohl commented Jan 16, 2025

MariaAga commented Jan 17, 2025

jeremylenz commented Jan 17, 2025

adamruzicka left a comment

ekohl commented Jan 20, 2025

MariaAga commented Jan 20, 2025

adamruzicka commented Jan 20, 2025

ekohl Jan 21, 2025

adamruzicka Jan 21, 2025

MariaAga Jan 21, 2025

ekohl Jan 21, 2025

Fixes #37382 - Update to jQuery 3 #10138

Fixes #37382 - Update to jQuery 3 #10138

Conversation

MariaAga commented Apr 24, 2024

ekohl commented Apr 24, 2024

MariaAga commented Apr 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ekohl left a comment

Choose a reason for hiding this comment

MariaAga commented Jul 18, 2024 • edited Loading

MariaAga commented Jan 9, 2025

jeremylenz left a comment

Choose a reason for hiding this comment

ekohl commented Jan 16, 2025

MariaAga commented Jan 17, 2025

jeremylenz commented Jan 17, 2025

adamruzicka left a comment

Choose a reason for hiding this comment

ekohl commented Jan 20, 2025

MariaAga commented Jan 20, 2025

adamruzicka commented Jan 20, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MariaAga commented Jul 18, 2024 •

edited

Loading