Add missing procedure to assembly #2965
Conversation
|
The PR preview for be623a1 is available at theforeman-foreman-documentation-preview-pr-2965.surge.sh The following output files are affected by this PR: |
maximiliankolb
force-pushed
the
host_collections
branch
2 times, most recently
from
988e125 to
5a17f4f
Compare
|
Rebased to "master" and simplified. Do you mind having a look @asteflova ? |
|
Everything looks ok, but as an alternative, how about moving the procedure from assembly_administering-hosts.adoc to assembly_configuring-host-collections.adoc? assembly_administering-hosts.adoc is really long. Too long for an assembly, IMO. A while ago, I moved all host group-related modules to a separate assembly in #2685 in an effort to make assembly_administering-hosts.adoc shorter and easier to take in. Moving proc_adding-a-host-to-a-host-collection.adoc could help too. But it's your call. |
* Previously, the procedure was only part of the "Administering Hosts" assembly. * Use sentence case for link
maximiliankolb
force-pushed
the
host_collections
branch
from
5a17f4f to
bf93a68
Compare
|
I applied your feedback on the second commit. This simplifies things tremendously. Good to go? @asteflova |
* "app/models/katello/host_collection.rb" in katello * cat app/views/unattended/report_templates/ansible_-_ansible_inventory.erb | grep Katello
* Make host collections katello-only * "app/models/katello/host_collection.rb" in katello * cat app/views/unattended/report_templates/ansible_-_ansible_inventory.erb | grep Katello (cherry picked from commit 87b93ce)
* Make host collections katello-only * "app/models/katello/host_collection.rb" in katello * cat app/views/unattended/report_templates/ansible_-_ansible_inventory.erb | grep Katello (cherry picked from commit 87b93ce)
Previously, the procedure was only part of the "Administering Hosts" assembly.
the workaround for the context is necessary because the guide contains boths assemblies but the anchors cannot both use the same context.
Please cherry-pick my commits into: