Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfixes #106

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Quickfixes #106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72b851a
New compilation error fix; minor comment on non-strong-exception safe…
thecppzoo Dec 5, 2024
aa81160
Injects avx and bmi into Xcode options without messing with the C++ s…
thecppzoo Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
New compilation error fix; minor comment on non-strong-exception safe… 
… assignment
  • Loading branch information
@thecppzoo
thecppzoo committed Dec 5, 2024
commit 72b851a6cbe2f6fc568c046d742c656300a54c65
4 changes: 3 additions & 1 deletion inc/zoo/AnyContainer.h
View file
Original file line number Diff line number Diff line change
@@ -298,7 +298,7 @@ struct MSVC_EMPTY_BASES AnyContainerBase:
{}

template<typename ValueType>
void emplaced(ValueType *ptr) noexcept { SuperContainer::template emplaced(ptr); }
void emplaced(ValueType *ptr) noexcept { SuperContainer::emplaced(ptr); }

AnyContainerBase &copy_assign(const AnyContainerBase &model) {
SuperContainer::copy_assign(model);
@@ -326,6 +326,8 @@ struct AnyCopyable: AnyContainerBase<Policy> {

AnyCopyable &operator=(AnyCopyable &&) = default;

/// \note Does not provide the strong exception safety guarantee
// Affordance of non-destructive copying?
AnyCopyable &operator=(const AnyCopyable &model) {
if constexpr(std::is_copy_constructible_v<Base>)this->copy_assign(model);
auto myself = this->container();