Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are a TON of warnings #126

Open
moon-chilled opened this issue Mar 17, 2017 · 3 comments
Open

There are a TON of warnings #126

moon-chilled opened this issue Mar 17, 2017 · 3 comments
Assignees
@thebracket
Labels
bug

Comments

@moon-chilled
Copy link

If you want, I can try to clean some of them up and make a PR, but there are a TON of them
@thebracket thebracket self-assigned this Mar 17, 2017
@thebracket thebracket added the bug label Mar 17, 2017
@thebracket
Copy link
Owner

You're absolutely right - there are a ton of warnings (depending upon which compiler you use, there are even more - GCC gives a lot more than Clang). My goal is to do a big cleanup on that (and some global variable issues) soon, but I want to stabilize some architecture decisions first. Thanks!

@thebracket
Copy link
Owner

thebracket commented Apr 6, 2017 •
edited
Loading

Two changes to RLTK just went up that massively reduced the number of warnings (especially on Clang). I'd omitted some braces in an initializer list (it still worked, oddly), in each and each_if - which are used everywhere. That's a good start! (I'll have the RLTK link updated in the main source shortly)

thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - RLTK update fixes quite a lot of warnings. Also moves ca…
6784011 
…mera preferences into a component, so they are persisted.
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - fix warning in harvest display code, which was also a st…
05e9ffb 
…upid performance bug.
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - remove an unused private variable in lighting system.
f5d8cc2
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - remove an unused variable in heightmap creation.
8588b53
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - fix an incorrect equality operator (meant to be assignme…
1a56b9a 
…nt) in blight builder.
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - remove unused variables in buildings.cpp
ca70f29
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - remove unused variable in region builder.
7561351
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - remove unused variable in sentient builder.
21613be
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - remove unused variables from planet builder.
109c89d
thebracket added a commit that referenced this issue Apr 6, 2017
@thebracket
Issue #126 - massive reduction in warnings, at least on Clang.
2f63d7e
@thebracket
Copy link
Owner

I just went on a big warning hunt, and removed a LOT of warnings from Clang builds. I'll have to do the same for GCC, but not today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thebracket thebracket

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moon-chilled @thebracket