Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy CSV to JSON browser script into gh-pages and restyling it #14

Merged
merged 5 commits into from
Aug 26, 2023
Merged

Conversation

IsmaCortGtz
Copy link
Contributor

Deploy CSV to JSON browser script into gh-pages and restyling it

This PR should help for the issue #7.

I added the implementation of my Browser runnable script for the issue #3, it can be accesed at the gh-page by a button, see the example here.

imagen

I changed the structure of many files in the docs/ folder. It to imrpove the scalability and the organization of the site.

And probably the most evident change, I add a styling of the page with some CSS rules, taking as principal color the image of the logo.

Again, you can see the result in my deploy here and test it if you want. 😁

I was testing with your repo and I think the gh-pages are deployed in the test_network branch. So maybe you have to change it if you accept this PR.

@thealphadollar
Copy link
Owner

Looks amazing! Thank you so much for the great work @IsmaCortGtz I especially like the styling contribution 💯

I have a small concern, I tried the demo and the button to download a single file wasn't working for me. Can you check if you can reproduce the error and then fix it? The button to download the entire zip is working perfectly.

image

@IsmaCortGtz
Copy link
Contributor Author

IsmaCortGtz commented Aug 23, 2023

Sure, I will check it. 😉

@IsmaCortGtz
Copy link
Contributor Author

Hi @thealphadollar. 👋

Now it works for me. I changed the API of the library but I forgot to update the usage in the web.

I have some bugs with service workers in my other gh-pages repos so maybe you could need to check If the older version is cached.

Tell me if you need something else.

@thealphadollar
Copy link
Owner

Thanks for the quick changes, man.

I'll have a look later tonight.

@thealphadollar thealphadollar changed the base branch from gh-pages to master August 23, 2023 17:16
@thealphadollar thealphadollar self-requested a review August 24, 2023 04:04
@thealphadollar thealphadollar merged commit 7b05fc9 into thealphadollar:master Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants