Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skiller_sgk50_s4 keyboard #2405

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Jan 23, 2025

Description

Update skiller_sgk50_s4 keyboard.

QMK Pull Request

qmk/qmk_firmware#24784

VIA Keymap Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Feb 6, 2025

The context for the update?

The changes proposed would not work at all with the board definitions in QMK code here and by extension in the VIA keymap as well in here.

Closing this PR for the moment, feel free to reopen it again once you apply the appropriate changes in QMK main as well as VIA userspace

@Cipulot Cipulot closed this Feb 6, 2025
@itarze
Copy link
Contributor Author

itarze commented Feb 7, 2025

@Cipulot The changed keymap has been merged into QMK. This PR

@Cipulot
Copy link
Collaborator

Cipulot commented Feb 7, 2025

@itarze thanks for pointing this out, this PR will then be put on hold since the QMK main PR targets develop, it being a Keeb change.
I'd also suggest to open a PR for the VIA keymap over in teh VIA userspace that will be merged once the next breaking changes are merged.

reason why the changes need to be n QMK main, and then in the userspace, is because the build script that gives out binaries in the via website targets main branch.

@Cipulot Cipulot reopened this Feb 7, 2025
@Cipulot Cipulot added develop merged Waiting for merge into QMK master pending VIA keymap merge Waiting for merge into VIA keymap labels Feb 7, 2025
@itarze
Copy link
Contributor Author

itarze commented Feb 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop merged Waiting for merge into QMK master pending VIA keymap merge Waiting for merge into VIA keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants