Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIA support for shuguet/shu89 split keyboard (PCB + Case are open-source) #2399

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

shuguet
Copy link
Contributor

@shuguet shuguet commented Dec 31, 2024

Description

Adding a keyboard and it's associated keymap.
This is an 89 keys split keyboard, made up of a single (breakable) PCB + a case (can be either 3D printed or CNC made).
Both case and PCBs are done, only the CNC technical drawings are left TODO.

QMK Pull Request

qmk/qmk_firmware#24758

VIA Keymap Pull Request

the-via/qmk_userspace_via#46

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@shuguet shuguet marked this pull request as ready for review January 27, 2025 13:12
@shuguet
Copy link
Contributor Author

shuguet commented Jan 27, 2025

Both upstream PRs have merged.

This is ready for review.

Thank you for your consideration!

src/shuguet/shu89/shu89.json Outdated Show resolved Hide resolved
@Cipulot
Copy link
Collaborator

Cipulot commented Feb 6, 2025

@shuguet pull the changes that I applied and move the file from src/shuguet/shu89/shu89.json to v3/shuguet/shu89/shu89.json.

The src folder is for legacy only and should not be used for new PRs

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Feb 6, 2025
@shuguet
Copy link
Contributor Author

shuguet commented Feb 6, 2025

@Cipulot done, at least I think that is what you requested?

Let me know if not, looking forward to get this merged!

@Cipulot Cipulot merged commit 655753e into the-via:master Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants