Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Adjustment #46

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Final Adjustment #46

merged 5 commits into from
Oct 8, 2023

Conversation

Satoshi-Sh
Copy link
Collaborator

@Satoshi-Sh Satoshi-Sh commented Oct 8, 2023

For an example of how to fill this template out, see this Pull Request.

Description

The input box overflows to the right. I fixed it by replacing flex-grow with w-full and adjusted the add item page layout accordingly.

Centered an error message of token input.

Acceptance Criteria

  • Please check the mobile view if the page overflows to the right.
  • Check if the token input error is displayed in the middle of the page.

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Visit the preview URL for this PR (updated for commit 541ea7a):

https://tcl-64-smart-shopping-list--pr46-ss-final-adjustment-zx4y9hl9.web.app

(expires Sun, 15 Oct 2023 05:21:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a60b3bbf6240277c6faac0e586ba48982028ef7b

@Satoshi-Sh Satoshi-Sh marked this pull request as ready for review October 8, 2023 03:22
@Satoshi-Sh Satoshi-Sh requested review from polly89 and ismarjiw October 8, 2023 03:22
@Satoshi-Sh Satoshi-Sh changed the title Ss final adjustment Final Adjustment Oct 8, 2023
@ismarjiw
Copy link
Collaborator

ismarjiw commented Oct 8, 2023

The X is fixed on my screen!
image

But now I can't see the add ítem button anymore. No matter if I try to force scroll down, the button settles behind the navbar.
image

@Satoshi-Sh
Copy link
Collaborator Author

The X is fixed on my screen! image

But now I can't see the add ítem button anymore. No matter if I try to force scroll down, the button settles behind the navbar. image

Thanks for checking, Ismarji. I don't know why this change takes up the space that much. I was about to sleep but I will have a look a bit.

Copy link
Collaborator

@polly89 polly89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Satoshi-Sh Satoshi-Sh merged commit bda4abf into main Oct 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants