Skip to content

Query: Enable promql-experimental-functions #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

heysujal
Copy link

@heysujal heysujal commented Apr 5, 2025

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #7640

In thanos/query.go

  1. Added "promql-experimental-functions" in query.go
  2. Added cmd.Flag for enableQueryExperimentalFunctions
  3. Updated FeatureList Description
  4. Added logger for promqlExperimentalFunctions flag
  5. Updated query builder for the same

Added entry for the same in pkg/api/query/engine.go , pkg/queryfrontend/config.go, and test/e2e/e2ethanos/services.go

Verification

@heysujal heysujal marked this pull request as draft April 5, 2025 20:40
@heysujal heysujal marked this pull request as ready for review April 9, 2025 18:00
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix build

heysujal and others added 6 commits April 19, 2025 23:36
Signed-off-by: Sujal Gupta <sujalgupta6100@gmail.com>
Signed-off-by: Sujal Gupta <sujalgupta6100@gmail.com>
Signed-off-by: Sujal Gupta <sujalgupta6100@gmail.com>
Adjust the default get-config timeout to match the default get-config
interval.

Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
Signed-off-by: Sujal Gupta <sujalgupta6100@gmail.com>
Signed-off-by: Sujal Gupta <sujalgupta6100@gmail.com>
Signed-off-by: Sujal Gupta <sujalgupta6100@gmail.com>
@heysujal heysujal requested a review from yeya24 April 19, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FT add feature flag for 'promql-experimental-functions'.
3 participants