Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not correctly generating releases #80

Open
Levi-Armstrong opened this issue Nov 8, 2023 · 1 comment
Open

Not correctly generating releases #80

Levi-Armstrong opened this issue Nov 8, 2023 · 1 comment

Comments

@Levi-Armstrong
Copy link
Contributor

Current releases have not been going through the correct release process so the package.xml and changelog has not been updated since version 0.18.X. Who ever is doing the releases for this package please make sure to do this. @marip8

@marip8
Copy link
Contributor

marip8 commented Nov 8, 2023

Correct. I've been generating releases to trigger the CI build that pushes docker images, since that is currently the only way to trigger the docker push stage of CI. These releases were for tags that were added in the history, so I was unable to go through the normal catkin_prepare_release process (for some of them at least).

Going forward, we should apply the catkin_prepare_release steps, at least for changes in minor versions. We'll just have to be cognizant of doing this before merging minor-version-breaking changes.

With regard to the releases I've been making recently, this is clearly not the best way of trigger the generation of new docker images for specific tags. What I would like to do is use the workflow_dispatch to trigger the CI and change the rule for the push step to allow the image to be pushed if the branch is a tag. I have yet to figure out how to do this successfully in Github Actions though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants