Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable collision shape caching in bullet and fcl #1116

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Jan 28, 2025

There seems to be an issue with reusing collision shapes in some cases. It odd that this causes issues but multiple clones do not which seem to share collision shapes.

@Levi-Armstrong Levi-Armstrong force-pushed the feat/disable-collision-shape-cache branch from 0816fe7 to 90154de Compare January 28, 2025 20:43
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (e2f847a) to head (90154de).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   88.69%   88.60%   -0.10%     
==========================================
  Files         296      296              
  Lines       16619    16611       -8     
==========================================
- Hits        14741    14718      -23     
- Misses       1878     1893      +15     

see 5 files with indirect coverage changes

@Levi-Armstrong Levi-Armstrong merged commit 708141a into tesseract-robotics:master Jan 29, 2025
13 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feat/disable-collision-shape-cache branch January 29, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant