Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file navigation #56

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Conversation

JohnSchmeichel
Copy link
Contributor

@JohnSchmeichel JohnSchmeichel commented Mar 6, 2023

I got used to left/right arrows to navigate between files so extending that to the files view (which also fixes a crash as those commands assumed a PatchDocument).

Also tweaking the file navigation a bit to make behavior a bit more consistent between the first and last files:

  1. If you are in the middle of a file then left arrow brings you to the start of that file: for long files found not having the ability to jump to the top of the file a bit limiting (could navigate to the previous then forward again, but then it was different for the first file)
  2. If you are in the last file then right arrow brings you to the last line of the document: found it very frustrating not being able to jump to the last line of the file.
  3. Change page up/down behavior by maintaining line position where possible and allowing the last line to be selected.
  4. Change hunk navigation behavior by selecting the start or end of the hunk if navigation has reached the first or last hunk, respectively.

@terrajobst terrajobst merged commit 13313aa into terrajobst:main Feb 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants