Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow Pipes with Kinesis Targets #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

soisyourface
Copy link

@soisyourface soisyourface commented Dec 6, 2024

Description

Add a dynamic block to the var.pipes[].target_parameters for kinesis_stream_parameters.partition_key.

Motivation and Context

module "doro-eventbridge" {
  source = "./modules/terraform-aws-eventbridge"
  # source   = "terraform-aws-modules/eventbridge/aws"
  # version  = "3.13.0"
  bus_name = "doro"

  pipes = {
    doro_test = {
      source = "${aws_kinesis_stream.streamA.arn}"
      target = "${aws_kinesis_stream.streamO.arn}"

      source_parameters = {
        kinesis_stream_parameters = {
          starting_position = "LATEST"
        }
      }
      target_parameters = {
        kinesis_stream_parameters = {
          partition_key = "$.deviceId"
        }
      }
    }
  }
}

Before the partition_key was not pulled in and therefore the create of the pipe always failed as it is a required field for creating a pipe with a kinesis target.

Breaking Changes

Additive so no expected breakage.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@soisyourface soisyourface changed the title Allow Pipes with Kinesis Targets fix: Allow Pipes with Kinesis Targets Dec 6, 2024
@soisyourface soisyourface mentioned this pull request Dec 10, 2024
1 task
Copy link

github-actions bot commented Jan 6, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 6, 2025
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants