Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding kms_key_identifierto aws_cloudwatch_event_bus and log_configuration.include_execution_data to aws_pipes_pipe #132

Merged

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Aug 31, 2024

Description

Add kms_key_identifier to aws_cloudwatch_event_bus
Add log_configuration.include_execution_data arg for aws_pipes_pipe

Motivation and Context

hashicorp/terraform-provider-aws#38569
hashicorp/terraform-provider-aws#38492

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

main.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs changed the title feat: Adding kms_key_identifierto aws_cloudwatch_event_bus and log_configuration.include_execution_data to aws_pipes_pipe` feat: Adding kms_key_identifierto aws_cloudwatch_event_bus and log_configuration.include_execution_data to aws_pipes_pipe Sep 5, 2024
@bryantbiggs bryantbiggs merged commit b7dadc0 into terraform-aws-modules:master Sep 5, 2024
16 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 5, 2024
## [3.10.0](v3.9.1...v3.10.0) (2024-09-05)

### Features

* Adding `kms_key_identifier`to `aws_cloudwatch_event_bus` and `log_configuration.include_execution_data` to `aws_pipes_pipe` ([#132](#132)) ([b7dadc0](b7dadc0))
@antonbabenko
Copy link
Member

This PR is included in version 3.10.0 🎉

Copy link

github-actions bot commented Oct 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants