feat: Added sns_kms_arns parameter for granular kms access inside sns aws_iam_policy resource #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aws_iam_policy resource
antonbabenko
approved these changes
Jul 5, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Jul 5, 2024
## [3.7.0](v3.6.0...v3.7.0) (2024-07-05) ### Features * Added sns_kms_arns parameter for granular kms access inside sns aws_iam_policy resource ([#129](#129)) ([c4188b7](c4188b7))
|
This PR is included in version 3.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds backwards compatible logic which gives the user the possibility to configure specific KMS arns, or even zero arns to to the policy related to SNS.
Motivation and Context
Currently a wildcard is used inside the iam policy which is something SecurityHub is complaining about.
Breaking Changes
It is backwards compatible as it uses the list ["*"] as default.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request