feat: Replace deprecated is_enabled with state in EventBridge rules #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for moving fw with this PR. |
|
@antonbabenko this looks like quick fix and easy to adopt in the module. It will allow all of us to stop be annoyed by the constant warnings during TF plan/apply. |
antonbabenko
requested changes
Apr 23, 2024
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
antonbabenko
approved these changes
Apr 23, 2024
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Apr 23, 2024
## [3.3.0](v3.2.4...v3.3.0) (2024-04-23) ### Features * Replace deprecated is_enabled with state in EventBridge rules ([#119](#119)) ([920138a](920138a))
|
This PR is included in version 3.3.0 🎉 |
|
Great news! Thank you for prompt response. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the aws_cloudwatch_event_rule resource definition in the Terraform configuration to replace the deprecated is_enabled attribute with the state attribute. This change ensures compatibility with the latest versions of the AWS provider.
Motivation and Context
This change is required to address deprecation warnings from the AWS provider for Terraform. The use of is_enabled has been deprecated and replaced by state, which is now required to define the enabled or disabled status of CloudWatch Event Rules.
Resolving this prevents potential issues with future versions of the AWS provider that may no longer support the is_enabled attribute, ensuring the stability and maintainability of the infrastructure code.
Breaking Changes
This change does not break backwards compatibility with the current major version of the module, as it merely replaces a deprecated attribute with its recommended alternative.
Users who rely on older versions of the AWS provider (before the introduction of the state attribute) should consider upgrading their provider to continue using this module.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed