fix: Made input_paths in input_transformer optional #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per AWS provider documentation, input_paths is not required.
rutgoff
changed the title
rutgoff
changed the title
|
Associated issue: #117 |
antonbabenko
changed the title
antonbabenko
approved these changes
Apr 5, 2024
antonbabenko
merged commit 1ce4aca
into
terraform-aws-modules:master
17 of 21 checks passed
|
Thank you @rutgoff ! |
antonbabenko
pushed a commit
that referenced
this pull request
Apr 5, 2024
## [3.2.4](v3.2.3...v3.2.4) (2024-04-05) ### Bug Fixes * Made input_paths in input_transformer optional ([#116](#116)) ([1ce4aca](1ce4aca))
|
This PR is included in version 3.2.4 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per AWS provider documentation,
input_pathsis not required.Fixes #117
Description
Per the AWS Provider documentation on aws_cloudwatch_event_target,
input_pathsis optional.Motivation and Context
Scenario:
You have a rule of type "Scehduled Standard" and a target of a Batch job queue. You wish to use an
input_transformerof type "Constant" and supply some static JSON forinput_template. This means you will not have any need forinput_paths. Currently the module requiresinput_pathsto be set.Breaking Changes
Not that I am aware
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsI use this module at my place of employment and have tested this change with our implementation of this module and confirmed the change requested here does not break usage of the module.
pre-commit run -aon my pull request