fix: Event bus data source count conditional

[magreenbaum]

Description

In several examples (api-gateway-event-source, with-archive, with-api-destination), any example where bus_name is known after apply (generated randomly in this case), there is an invalid count argument error:

 Error: Invalid count argument
│ 
│   on ../../main.tf line 59, in data "aws_cloudwatch_event_bus" "this":
│   59:   count = (var.create && var.create_bus) || (var.bus_name == "") ? 0 : 1
│ 
│ The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To work
│ around this, use the -target argument to first apply only the resources that the count depends on.
╵

We can prevent this by removing the || (var.bus_name == "") in the count conditional.
bus_name defaults to default and I'm not seeing a use case where bus_name would be set to an empty string without producing errors for other reasons.

Motivation and Context

Remediate invalid count argument error.

Breaking Changes

No.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[magreenbaum]

Unstale

[antonbabenko]

This PR is included in version 3.0.1 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.