-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add appsync arguments to support appsync security features #61
feat: Add appsync arguments to support appsync security features #61
Conversation
…y depth and introspection features.
@antonbabenko could I request your review on this PR please? |
@antonbabenko - is there anything else you would need me to do on this PR before it can be merged? Thanks. |
variables.tf
Outdated
variable "introspection_config" { | ||
description = "Whether to enable or disable introspection of the GraphQL API." | ||
type = string | ||
default = "ENABLED" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the default value for all 3 new variables to null
and remove validation
section entirely from all variables.
@antonbabenko - done. Would you mind re-reviewing please? |
## [2.5.0](v2.4.1...v2.5.0) (2024-03-20) ### Features * Add appsync arguments to support appsync security features ([#61](#61)) ([355de62](355de62))
This PR is included in version 2.5.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support for the new AppSync GraphQL controls for query depth, run complexity and introspection.
Motivation and Context
This enables users to utilise the new AppSync features that improve the security of their AppSync APIs.
Breaking Changes
This increases the minimum AWS provider version to 5.37, as this was the terraform provider that implemented these controls.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request