-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the max line length of python files to 80 #278
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default line length setting in Python, particularly when using the pre-commit framework with the black formatter, is 88 characters. This is specified by black as its default line length, which is designed to promote readability while accommodating common display widths.
Let's just be consistent across projects if possible. Check what tt-mlir is using (and other frontends preferably). I think they all inherit this default behaviour specified by pre commit configuration.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 78.09% 78.09%
=======================================
Files 21 21
Lines 986 986
=======================================
Hits 770 770
Misses 216 216 ☔ View full report in Codecov by Sentry. |
@kmitrovicTT I have put the 80 here as that was advised by @mrakitaTT in another PR for docstrings. I have checked other frontends and tt-mlir. |
Setting the max line length to 80 of our python files.