Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the max line length of python files to 80 #278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajakovljevicTT
Copy link
Contributor

Setting the max line length to 80 of our python files.

Copy link
Contributor

@kmitrovicTT kmitrovicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://pre-commit.com/

The default line length setting in Python, particularly when using the pre-commit framework with the black formatter, is 88 characters. This is specified by black as its default line length, which is designed to promote readability while accommodating common display widths.

Let's just be consistent across projects if possible. Check what tt-mlir is using (and other frontends preferably). I think they all inherit this default behaviour specified by pre commit configuration.

Copy link

github-actions bot commented Feb 25, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-XLA Tests599 ran434 passed165 skipped0 failed
TestResult
No test annotations available

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.09%. Comparing base (93f80e3) to head (6c49a36).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   78.09%   78.09%           
=======================================
  Files          21       21           
  Lines         986      986           
=======================================
  Hits          770      770           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajakovljevicTT
Copy link
Contributor Author

From https://pre-commit.com/

The default line length setting in Python, particularly when using the pre-commit framework with the black formatter, is 88 characters. This is specified by black as its default line length, which is designed to promote readability while accommodating common display widths.

Let's just be consistent across projects if possible. Check what tt-mlir is using (and other frontends preferably). I think they all inherit this default behaviour specified by pre commit configuration.

@kmitrovicTT I have put the 80 here as that was advised by @mrakitaTT in another PR for docstrings. I have checked other frontends and tt-mlir. TT-forge has line length 120, and tt-torch and tt-mlir leave the default options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants