New tt-mlir installation support #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tt-mlir PR for more information: tenstorrent/tt-mlir#2108
nsmithtt
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
|
||||||||||||||
|
Rollout plan,
|
mrakitaTT
approved these changes
Feb 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 78.25% 78.06% -0.20%
==========================================
Files 21 21
Lines 1044 1044
==========================================
- Hits 817 815 -2
- Misses 227 229 +2 ☔ View full report in Codecov by Sentry. |
|
@nsmithtt Thank you for making these changes! I'll proceed merging them to unblock the uplift. |
ajakovljevicTT
pushed a commit
that referenced
this pull request
Feb 20, 2025
Adopt the new way that tt-mlir builds and links: - Packages all of tt-mlir + downstream tt-metal libs and files into installation prefix for easy deployment - Statically links `libTTMLIRCompiler.so` and `libTTMLIRRuntime.so`, now FE's only need to link against these 2 binaries and no other deps. See tt-mlir PR for more information: tenstorrent/tt-mlir#2108 --------- Co-authored-by: Marko Rakita <mrakita@tenstorrent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the new way that tt-mlir builds and links:
libTTMLIRCompiler.soandlibTTMLIRRuntime.so, now FE's only need to link against these 2 binaries and no other deps.See tt-mlir PR for more information:
tenstorrent/tt-mlir#2108