Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fail reasons #255

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

sgligorijevicTT
Copy link
Contributor

@sgligorijevicTT sgligorijevicTT commented Feb 13, 2025

Ticket

Fixes #171

Problem description

Reasons should be kept up to date

What's changed

I updated the fail reasons

Copy link

github-actions bot commented Feb 13, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-XLA Tests599 ran431 passed168 skipped0 failed
TestResult
No test annotations available

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (a24db33) to head (b5e8ad0).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   78.06%   78.06%           
=======================================
  Files          21       21           
  Lines        1044     1044           
=======================================
  Hits          815      815           
  Misses        229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmitrovicTT
Copy link
Contributor

@sgligorijevicTT does this mean #171 is gone?

@sgligorijevicTT
Copy link
Contributor Author

@sgligorijevicTT does this mean #171 is gone?

Yes. I think it was fixed when tt-mlir added ttnn.to_dtype.

Copy link
Contributor

@kmitrovicTT kmitrovicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgligorijevicTT please close #171 with this PR then.

@sgligorijevicTT sgligorijevicTT merged commit 19928a2 into main Feb 24, 2025
8 checks passed
@sgligorijevicTT sgligorijevicTT deleted the sgligorijevic/update-fail-reasons-20250213 branch February 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get the device from a tensor with host storage
3 participants