Adding infrastructure for multichip tests #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajakovljevicTT
requested review from
kmitrovicTT and
mrakitaTT
as code owners
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_multichip_tests
branch
4 times, most recently
from
60f1a95 to
d2dcb1e
Compare
|
||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 77.82% 78.09% +0.27%
==========================================
Files 21 21
Lines 1028 986 -42
==========================================
- Hits 800 770 -30
+ Misses 228 216 -12 ☔ View full report in Codecov by Sentry. |
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_multichip_tests
branch
from
4c2f7ac to
0086d31
Compare
kmitrovicTT
reviewed
Feb 5, 2025
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_multichip_tests
branch
2 times, most recently
from
148c3ae to
aaf46cf
Compare
kmitrovicTT
reviewed
Feb 6, 2025
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_multichip_tests
branch
3 times, most recently
from
ec6db0f to
1863d25
Compare
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_multichip_tests
branch
2 times, most recently
from
c9b3693 to
20542c4
Compare
kmitrovicTT
approved these changes
Feb 24, 2025
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_multichip_tests
branch
from
20542c4 to
4aeb594
Compare
mrakitaTT
approved these changes
Feb 24, 2025
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_multichip_tests
branch
from
4aeb594 to
3baadca
Compare
ajakovljevicTT
added a commit
that referenced
this pull request
Feb 26, 2025
Part of issue #211 Integrating new tester class, called `MultichipTester`, into our testing infrastructure in`tt-xla`. It will receive the input and output shardings from the user, the function to be tested, and the golden function which will run on CPU, in a non-sharded mode. It runs the received data and compared the results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Part of issue #211
Problem description
Integrating new tester class, called
MultichipTester, into our testing infrastructure intt-xla. It will receive the input and output shardings from the user, the function to be tested, and the golden function which will run on CPU, in a non-sharded mode. It runs the received data and compared the results.