Add MNIST MLP test #205
Merged
Add MNIST MLP test #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
|
||||||||||||||
sgligorijevicTT
force-pushed
the
sgligorijevic/add-mnist-mlp-test
branch
from
9fc4fb7 to
a7452f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 21 21
Lines 1006 1006
=======================================
Hits 775 775
Misses 231 231 ☔ View full report in Codecov by Sentry. |
mrakitaTT
reviewed
Jan 30, 2025
sgligorijevicTT
force-pushed
the
sgligorijevic/add-mnist-mlp-test
branch
from
a7452f9 to
28a6569
Compare
mrakitaTT
reviewed
Jan 31, 2025
mrakitaTT
approved these changes
Jan 31, 2025
mrakitaTT
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
This addresses one part of #203
Problem description
Test for a simple MLP for MNIST was missing
What's changed
Added a new test
Checklist