Correct the tt-mlir path in get-docker-tag.sh #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the path to match path where Cmake ExternalProject_Add clones tt-mlir
vmilosevic
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
mrakitaTT
approved these changes
Jan 27, 2025
|
||||||||||||||
Cmake expexts that folder used for external project is empty. Use different folder to checkout tt-mlir 0.695 CMake Error at CMakeLists.txt:19 (message): 0.695 Failed to clone tt-mlir: fatal: destination path 0.695 '/home/build/tt-xla/third_party/tt-mlir/src/tt-mlir' already exists and is 0.695 not an empty directory.
mrakitaTT
reviewed
Jan 27, 2025
sdjukicTT
pushed a commit
that referenced
this pull request
Jan 29, 2025
Script get-docker-tag.sh was incorrectly generating docker tag, it didn't take into account tt-mlir docker tag change. Correct the path to match path where cmake ExternalProject_Add clones tt-mlir to gix the docker tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script get-docker-tag.sh was incorrectly generating docker tag, it didn't take into account tt-mlir docker tag change.
Correct the path to match path where cmake ExternalProject_Add clones tt-mlir to gix the docker tag.