Fix MLPMixer test #183
Merged
Fix MLPMixer test #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
kmitrovicTT
approved these changes
Jan 23, 2025
sgligorijevicTT
force-pushed
the
sgligorijevic/fix-mlpmixer-test
branch
from
8cd3407 to
6dc3477
Compare
|
||||||||||||||
sdjukicTT
pushed a commit
that referenced
this pull request
Jan 29, 2025
sdjukicTT
pushed a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my original test implementation, the model was instantiated slightly differently from how that is done in the original repo. This PR changes that. It also has the side effect of bypassing the error in MLIR and allowing the model to compile.