Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNIST CNN test fails #204

Closed
sgligorijevicTT opened this issue Jan 29, 2025 · 1 comment · Fixed by #207
Closed

MNIST CNN test fails #204

sgligorijevicTT opened this issue Jan 29, 2025 · 1 comment · Fixed by #207
Labels
models blocker Issues blocking models bringup

Comments

@sgligorijevicTT
Copy link
Contributor

Test for MNIST CNN fails with

void mlir::OperationConverter::finalize(ConversionPatternRewriter &): Assertion `newValue && "replacement value not found"' failed.

Root cause is that StableHLO conversion for reduce_window deletes the initial value, which might be used elsewhere.
Will be fixed by tenstorrent/tt-mlir#2007
@sgligorijevicTT sgligorijevicTT added the models blocker Issues blocking models bringup label Jan 29, 2025
@sgligorijevicTT
Copy link
Contributor Author

Second variant of MNIST CNN on PR ( #207 ) fails with error

error: failed to legalize unresolved materialization from () to 'tensor<1xf32>' that remained live after conversion

It will also be fixed by the same mlir PR.

@sgligorijevicTT sgligorijevicTT mentioned this issue Jan 31, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
models blocker Issues blocking models bringup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a second variant of MNIST CNN tenstorrent/tt-xla
1 participant
@sgligorijevicTT