Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename P150A to P150 #538

Merged
merged 2 commits into from
Feb 25, 2025
+8 −8
Merged

Rename P150A to P150 #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d79b4ae
Rename P150A to P150
pjanevskiTT Feb 24, 2025
1ac66d5
Address comments
pjanevskiTT Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions device/api/umd/device/types/cluster_descriptor_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ enum BoardType : uint32_t {
N150,
N300,
P100,
P150A,
P150,
P300,
GALAXY,
UNKNOWN,
Expand All @@ -60,7 +60,7 @@ inline BoardType get_board_type_from_board_id(const uint64_t board_id) {
} else if (upi == 0x43) {
return BoardType::P100;
} else if (upi == 0x40 || upi == 0x41) {
return BoardType::P150A;
return BoardType::P150;
}

throw std::runtime_error(fmt::format("No existing board type for board id {}", board_id));
Expand Down
2 changes: 1 addition & 1 deletion device/blackhole/blackhole_implementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ std::vector<tt_xy_pair> get_pcie_cores(const BoardType board_type, const bool is

if (board_type == BoardType::UNKNOWN || board_type == BoardType::P100) {
return PCIE_CORES_TYPE1;
} else if (board_type == BoardType::P150A) {
} else if (board_type == BoardType::P150) {
return PCIE_CORES_TYPE2;
} else if (board_type == BoardType::P300) {
return is_chip_remote ? PCIE_CORES_TYPE1 : PCIE_CORES_TYPE2;
Expand Down
6 changes: 3 additions & 3 deletions device/tt_cluster_descriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ std::unique_ptr<tt_ClusterDescriptor> tt_ClusterDescriptor::create_mock_cluster(
board_type = BoardType::N150;
break;
case tt::ARCH::BLACKHOLE:
board_type = BoardType::P150A;
board_type = BoardType::P150;
break;
default:
board_type = BoardType::UNKNOWN;
Expand Down Expand Up @@ -752,8 +752,8 @@ void tt_ClusterDescriptor::load_chips_from_connectivity_descriptor(YAML::Node &y
board_type = BoardType::N300;
} else if (chip_board_type.second == "p100") {
board_type = BoardType::P100;
} else if (chip_board_type.second == "p150A") {
board_type = BoardType::P150A;
} else if (chip_board_type.second == "p150A" || chip_board_type.second == "p150") {
board_type = BoardType::P150;
} else if (chip_board_type.second == "p300") {
board_type = BoardType::P300;
} else if (chip_board_type.second == "GALAXY") {
Expand Down
2 changes: 1 addition & 1 deletion device/tt_soc_descriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ std::string tt_SocDescriptor::get_soc_descriptor_path(
if (board_type == BoardType::P100 || board_type == BoardType::UNKNOWN) {
// TODO: this path needs to be changed to point to soc descriptors outside of tests directory.
return tt::umd::utils::get_abs_path("tests/soc_descs/blackhole_140_arch_no_eth.yaml");
} else if (board_type == BoardType::P150A) {
} else if (board_type == BoardType::P150) {
// TODO: this path needs to be changed to point to soc descriptors outside of tests directory.
return tt::umd::utils::get_abs_path("tests/soc_descs/blackhole_140_arch_type2.yaml");
} else if (board_type == BoardType::P300) {
Expand Down
2 changes: 1 addition & 1 deletion tests/blackhole/test_chip_info_bh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ TEST(BlackholeChipInfo, BasicChipInfo) {

const ChipInfo chip_info = tt_device->get_chip_info();

EXPECT_TRUE(chip_info.board_type == BoardType::P100 || chip_info.board_type == BoardType::P150A);
EXPECT_TRUE(chip_info.board_type == BoardType::P100 || chip_info.board_type == BoardType::P150);

EXPECT_TRUE(chip_info.chip_uid.asic_location == 0 || chip_info.chip_uid.asic_location == 1);
}
Expand Down
Loading