-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize cluster into yaml #499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0749a5
to
41c8d58
Compare
@cfjchu can you check whether this API would satisfy your requirements. Next step is going to be expanding cluster yaml with all the info needed. But I think we can fix the API now |
cfjchu
reviewed
Feb 5, 2025
cfjchu
reviewed
Feb 5, 2025
6822c66
to
cb26441
Compare
6249054
to
c43a604
Compare
broskoTT
reviewed
Feb 6, 2025
broskoTT
approved these changes
Feb 6, 2025
cb26441
to
2e367b4
Compare
c43a604
to
9be4d6b
Compare
516d5ec
to
9e28d05
Compare
bbd4ed8
to
1ef9383
Compare
a145bf6
to
add80a7
Compare
9e28d05
to
353ed96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solving part of #431
Description
Add a function to serialize cluster to the yaml (reverse of what we were doing so far). Add flag to all Cluster constructors to create mock chips inside Cluster if user wants that. Expose this (de)serializing through the API as mentioned in the issue above. Output yaml look like (note the styling difference than original, but in YAML world it is the same)
List of the changes
Testing
CI + new test
API Changes
Added create_mock_chips to Cluster constuctors, but changes not needed in UMD clients.