Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ubench in CI #305

Merged
merged 4 commits into from
Nov 23, 2024
Merged

Build ubench in CI #305

merged 4 commits into from
Nov 23, 2024

Conversation

joelsmithTT
Copy link
Contributor

@joelsmithTT joelsmithTT commented Nov 15, 2024

Issue

N/A

Description

tests/microbenchmark wasn't getting built by CI

List of the changes

modify CI yaml to build it with the unit tests

Testing

Builds locally, CI test pending

API Changes

There are no API changes in this PR.

@joelsmithTT joelsmithTT requested a review from broskoTT November 15, 2024 15:29
@joelsmithTT joelsmithTT merged commit 59d5b51 into main Nov 23, 2024
19 of 22 checks passed
@joelsmithTT joelsmithTT deleted the joelsmith/build-ubench-in-ci branch November 23, 2024 19:36
broskoTT added a commit that referenced this pull request Nov 26, 2024
broskoTT added a commit that referenced this pull request Nov 26, 2024
This reverts commit 59d5b51.

### Issue
No issue

### Description
Previous PR broke tt_metal build:
https://github.com/tenstorrent/tt-metal/actions/runs/12030573411

### List of the changes
- git revert 59d5b51

### Testing
This issue doesn't show up in tt_metal post commit after this revert:
https://github.com/tenstorrent/tt-metal/actions/runs/12030762771

### API Changes
There are no API changes in this PR.
broskoTT pushed a commit that referenced this pull request Nov 27, 2024
### Issue
N/A

### Description
tests/microbenchmark wasn't getting built by CI

### List of the changes
modify CI yaml to build it with the unit tests

### Testing
Builds locally, CI test pending

### API Changes
There are no API changes in this PR.
joelsmithTT added a commit that referenced this pull request Nov 28, 2024
### Issue
N/A

### Description
tests/microbenchmark wasn't getting built by CI

### List of the changes
modify CI yaml to build it with the unit tests

### Testing
Builds locally, CI test pending

### API Changes
There are no API changes in this PR.
@pjanevskiTT pjanevskiTT mentioned this pull request Feb 6, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants